https://bugzilla.redhat.com/show_bug.cgi?id=2482667

Mikel Olasagasti Uranga <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(mikel@olasagasti. |
                   |info)                       |



--- Comment #8 from Mikel Olasagasti Uranga <[email protected]> ---
thanks for pinging.

this is better, but not all ldflags are OK.

> export GO_LDFLAGS="-X main.version=%{version} \
>                    -X main.commit=%{release_commit} \
>                    -X main.date=$(date -d "@${SOURCE_DATE_EPOCH}" 
> +%Y-%m-%dT%H:%M:%SZ) \
>                    -X main.builtBy=Fedora"

Upstream does the followng:

>     ldflags:
>       - -s -w -X main.version={{.Version}} -X main.commit={{.ShortCommit}} -X 
> main.date={{.Date}}

Thus the builtBy is not required.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2482667

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202482667%23c8

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to