https://bugzilla.redhat.com/show_bug.cgi?id=2490148
--- Comment #1 from Mikel Olasagasti Uranga <[email protected]> --- - naming: node_exporter's package is named node-exporter, it doesn't have a prometheus- suffix, so I guess prometheus-snmp-exporter could just be snmp-exporter. - provides: upstream package name is snmp_exporter, it would be great to have a "provides" with that name as node-exporter does: Provides: snmp_exporter - generator binary if the binary will be named snmp_exporter, I think it's safe to name the generator with snmp_generator. Instead of doing this: > for cmd in generator; do > %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd > done You can do the following and control the generated binary name: %gobuild -o %{gobuilddir}/bin/snmp_generator %{goipath}/generator So you would need to adapt these to the new name: mv %{buildroot}%{_bindir}/generator %{buildroot}%{_bindir}/prometheus-snmp-generator (...) %{_bindir}/prometheus-snmp-generator - systemd Needs to depend on systemd-rpm-macros based on https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#packaging BuildRequires: systemd-rpm-macros - prometheus user Service depends on prometheus user, but it's creation is not included in the spec file. Check how `prometheus` packages does it and https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/ as extra help if needed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2490148 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202490148%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
