https://bugzilla.redhat.com/show_bug.cgi?id=2404856
Simone Caronni <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. |needinfo?(pavel.androniychu |com) |[email protected]) --- Comment #30 from Simone Caronni <[email protected]> --- The package looks good to me. Just a few points: - Why is it called xpu-smi instead of xpumanager? - There is a folder called THIRD_PARTY_LICENSES. If the tarball is shipping code using some of the sources mentioned in the folder, the License field needs to be updated for that. - What is the point of the devel subpackage with just the unversioned shared object? How are you supposed to consume/link to the library? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2404856 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202404856%23c30 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
