https://bugzilla.redhat.com/show_bug.cgi?id=2499893
Steve Cossette <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Steve Cossette <[email protected]> --- Some early review notes: I believe the Version field needs to be blank here, otherwise as you can see in the naming of your srpm, it adds version information twice: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_example Upstream recommends getting qt6-core and qt6-gui. It's possible those are being brought in by something else, and those requirements are in the CMakeLists.txt, so I recommend uncommenting them as, if something in the stack changes and those are no longer automatically brought in, building would fail. Secondly, do consider using the cmake() names for the devel packages. For example: ``` #BuildRequires: qt6-core-devel #BuildRequires: qt6-gui-devel BuildRequires: kf6-kio-devel ``` Would become ``` #BuildRequires: cmake(Qt6Core) #BuildRequires: cmake(Qt6Gui) BuildRequires: cmake(KF6KIO) ``` Third, usually, if you build using the KDE stack and ECM, you do want to use %cmake_kf6 instead of %cmake. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2499893 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202499893%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
