https://bugzilla.redhat.com/show_bug.cgi?id=2500839

Cole Robinson <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([email protected]
                   |                            |om)



--- Comment #4 from Cole Robinson <[email protected]> ---
When posting updated packaging, please use formatting something like

spec URL: X
srpm URL: Y

src.rpm is often a necessary component since it contains any patches, if there
are custom patches. But I found the srpm so we are good.

The spec file has `License: FIXME`. License value for this case should be

  License: MIT AND (MIT OR Apache-2.0) AND (Unlicense OR MIT)

(Look for `BEGIN LICENSE SUMMARY` in the build output and then AND those
together to get that value)

Besides that, the only difference in the spec from stock rust2rpm output is
disabling tests that aren't expected to pass, which is fine.
Hopefully those are covered by a rust2rpm.toml config so it's easy to reproduce
on future updates.

I confirmed this builds and installs on rawhide, so it all looks good. Just
post with fixed license tag and I'll approve.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2500839

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202500839%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to