https://bugzilla.redhat.com/show_bug.cgi?id=2357479
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #15 from Ben Beasley <[email protected]> --- Yes, I think that between upstream accepting and merging https://github.com/raspberrypi/libpisp/pull/74, and you applying that PR downstream as a patch, the issue of CC0-1.0 meson.build code files is resolved. I do think that you should add a link to the upstream PR in a comment above Patch0, both to make it more clear to a casual reviewer that the license patch does come from upstream, and to satisfy https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/. I do see that several files are licensed “GPL-2.0-only WITH Linux-syscall-note”: src/libpisp/backend/pisp_be_config.h src/libpisp/common/pisp_common.h src/libpisp/frontend/pisp_fe_config.h src/libpisp/frontend/pisp_statistics.h This is fine, because this is already on the allowed-licenses list, but it needs to be in the License expression (“BSD-3-Clause AND GPL-2.0-only WITH Linux-syscall-note”), preferably with a license-breakdown comment mentioning which files are which. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2357479 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202357479%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
