https://bugzilla.redhat.com/show_bug.cgi?id=2501790

Emmanuel Seyman <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Emmanuel Seyman <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: Add build-require 'coreutils' - it is needed for %{_fixperms}
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-Proc-Wait3-0.05-37.fc45.x86_64.rpm | sort | uniq -c |

$ rpm -qp --requires perl-Badger-0.16-1.fc45.noarch.rpm | sort | uniq -c | grep
-v rpmlib
      1 perl(Badger)
      1 perl(Badger::Apps)
      1 perl(Badger::Base)
      1 perl(Badger::Class)
      1 perl(Badger::Codec::Chain)
      1 perl(Badger::Codecs)
      1 perl(Badger::Config)
      1 perl(Badger::Config::Item)
      1 perl(Badger::Config::Schema)
      1 perl(Badger::Constants)
      1 perl(Badger::Data::Facet::Class)
      1 perl(Badger::Data::Facets)
      1 perl(Badger::Data::Type::Class)
      1 perl(Badger::Debug)
      1 perl(Badger::Exception)
      1 perl(Badger::Exporter)
      1 perl(Badger::Factory::Class)
      1 perl(Badger::Filesystem)
      1 perl(Badger::Filesystem::Directory)
      1 perl(Badger::Filesystem::File)
      1 perl(Badger::Hub)
      1 perl(Badger::Rainbow)
      1 perl(Badger::Reporter::App)
      1 perl(Badger::Test::Manager)
      1 perl(Badger::Timestamp)
      1 perl(base)
      1 perl(bytes)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Cwd)
      1 perl(Digest::MD5)
      1 perl(Encode)
      1 perl(File::Copy)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(IO::Dir)
      1 perl(IO::File)
      1 perl(lib)
      1 perl-libs
      1 perl(MIME::Base64)
      1 perl(overload)
      1 perl(POSIX)
      1 perl(Scalar::Util)
      1 perl(Storable)
      1 perl(strict)
      1 perl(Time::Local)
      1 perl(:VERSION) >= 5.8.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Badger-0.16-1.fc45.noarch.rpm | sort | uniq -c | grep
-v rpmlib
[snipped]
Binary provides are Ok.

$ rpmlint ./perl-Badger*
2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0
badness; has taken 0.3 s

The package is in line with Fedora and Perl packaging guide lines.
Please correct the 'FIX' item and consider fixing the 'TODO' item.

Resolution:
Approved


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2501790

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202501790%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to