https://bugzilla.redhat.com/show_bug.cgi?id=2503118
--- Comment #4 from Jerry James <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - The main package installs files into /usr/share/icons/hicolor, so it should have "Requires: hicolor-icon-theme". - The rpmfusion-free repository already has amule (2.x). Are you coordinating with the rpmfusion folks to make a clean transition? - The files src/Parser.{cpp,hpp} and src/webserver/src/php_parser.{c,h} have a license of "GPL-3.0-or-later WITH Bison-exception-2.2". - The files src/libs/common/MD5Sum.{cpp,h} have a license of RSA-MD, but according to https://docs.fedoraproject.org/en-US/legal/misc/#_licensing_of_rsa_implementations_of_md5 you shouldn't do anything about that. So this is not an issue; just noting it so it appears in the review. - Note the message below: "Large data in /usr/share should live in a noarch subpackage if package is arched." I'll leave this up to your discretion. Do you think it would advantageous to move those almost 6MB of data into noarch subpackages? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v2.0 or later", "GNU General Public License", "GNU General Public License v3.0 or later", "GNU General Public License, Version 2", "BSD 2-Clause License and/or GNU Lesser General Public License, Version 2.1", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "BSD 2-Clause License", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "NTP License", "*No copyright* GNU General Public License v2.0 or later", "*No copyright* Apache License 2.0", "MIT License". 653 files have unknown license. See above for license notes. [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/256x256 See note above about hicolor-icon-theme. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 409466 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5918720 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: amule-3.0.1-1.20260721git3cfd01f.fc45.x86_64.rpm amule-nogui-3.0.1-1.20260721git3cfd01f.fc45.x86_64.rpm amule-3.0.1-1.20260721git3cfd01f.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp11rhi140')] checks: 32, packages: 3 amule.x86_64: E: uncompressed-zip /usr/share/amule/skins/priscilla.zip amule.src: E: spelling-error ('eDonkey', 'Summary(en_US) eDonkey -> e Donkey, donkey, monkey') amule.src: E: spelling-error ('xMule', '%description -l en_US xMule -> x Mule, mule, Mullen') amule.src: E: spelling-error ('eMule', '%description -l en_US eMule -> e Mule, mule, Lemuel') amule.x86_64: E: spelling-error ('eDonkey', 'Summary(en_US) eDonkey -> e Donkey, donkey, monkey') amule.x86_64: E: spelling-error ('xMule', '%description -l en_US xMule -> x Mule, mule, Mullen') amule.x86_64: E: spelling-error ('eMule', '%description -l en_US eMule -> e Mule, mule, Lemuel') amule.x86_64: W: incoherent-version-in-changelog 3.0.1-1 ['3.0.1-1.20260721git3cfd01f.fc45', '3.0.1-1.20260721git3cfd01f'] 3 packages and 0 specfiles checked; 7 errors, 1 warnings, 11 filtered, 7 badness; has taken 1.0 s Rpmlint (debuginfo) ------------------- Checking: amule-debuginfo-3.0.1-1.20260721git3cfd01f.fc45.x86_64.rpm amule-nogui-debuginfo-3.0.1-1.20260721git3cfd01f.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp62drteax')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 24 filtered, 0 badness; has taken 2.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 amule.x86_64: E: uncompressed-zip /usr/share/amule/skins/priscilla.zip amule.x86_64: E: spelling-error ('eDonkey', 'Summary(en_US) eDonkey -> e Donkey, donkey, monkey') amule.x86_64: E: spelling-error ('xMule', '%description -l en_US xMule -> x Mule, mule, Mullen') amule.x86_64: E: spelling-error ('eMule', '%description -l en_US eMule -> e Mule, mule, Lemuel') amule.x86_64: W: incoherent-version-in-changelog 3.0.1-1 ['3.0.1-1.20260721git3cfd01f.fc45', '3.0.1-1.20260721git3cfd01f'] 4 packages and 0 specfiles checked; 4 errors, 1 warnings, 37 filtered, 4 badness; has taken 1.9 s Source checksums ---------------- https://github.com/amule-org/amule/archive/3cfd01faabed0757ba7b506e50f033c9cfd560e7/amule-3cfd01faabed0757ba7b506e50f033c9cfd560e7.tar.gz : CHECKSUM(SHA256) this package : 708a6681718519cdea22f535a335873a73a363297a86e710e3baaa05c4e796cd CHECKSUM(SHA256) upstream package : 708a6681718519cdea22f535a335873a73a363297a86e710e3baaa05c4e796cd Requires -------- amule (rpmlib, GLIBC filtered): libayatana-appindicator3.so.1()(64bit) libc.so.6()(64bit) libcryptopp.so.8()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libixml.so.11()(64bit) libm.so.6()(64bit) libmaxminddb.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libupnp.so.22()(64bit) libwx_baseu-3.2.so.0()(64bit) libwx_baseu-3.2.so.0(WXU_3.2)(64bit) libwx_baseu_net-3.2.so.0()(64bit) libwx_baseu_net-3.2.so.0(WXU_3.2)(64bit) libwx_gtk3u_core-3.2.so.0()(64bit) libwx_gtk3u_core-3.2.so.0(WXU_3.2)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) amule-nogui (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcryptopp.so.8()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libixml.so.11()(64bit) libm.so.6()(64bit) libmaxminddb.so.0()(64bit) libreadline.so.8()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libupnp.so.22()(64bit) libwx_baseu-3.2.so.0()(64bit) libwx_baseu-3.2.so.0(WXU_3.2)(64bit) libwx_baseu_net-3.2.so.0()(64bit) libwx_baseu_net-3.2.so.0(WXU_3.2)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) rtld(GNU_HASH) Provides -------- amule: amule amule(x86-64) application() application(org.amule.aMule.desktop) metainfo() metainfo(org.amule.aMule.metainfo.xml) mimehandler(x-scheme-handler/ed2k) mimehandler(x-scheme-handler/magnet) amule-nogui: amule-nogui amule-nogui(x86-64) bundled(nodejs-htm) bundled(nodejs-preact) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2503118 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: R, Java, SugarActivity, Haskell, fonts, PHP, Ocaml, Ruby, Python, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2503118 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202503118%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
