https://bugzilla.redhat.com/show_bug.cgi?id=2497530
Jitka Plesnikova <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] Flags| |fedora-review+ Status|NEW |ASSIGNED CC| |[email protected] --- Comment #2 from Jitka Plesnikova <[email protected]> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires: FIX: Add 'perl(Module::Install::Metadata)' and 'perl(Module::Install::WriteAll)' to BuildRequires - they provide 'all_from', 'requires', 'test_requires' and 'WriteAll' used in Makefile.PL and the bundled inc/ is removed in %prep. FIX: Add 'perl(IO::Socket::UNIX)' to BuildRequires (test dependency used in t/10unix_domain_socket.t). FIX: Remove duplicate 'perl(IO::Socket::INET)' from test requirements section - it is already listed in the runtime requirements section. $ rpm -qp --requires perl-Starlet-0.32-2.fc45.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Fcntl) 1 perl(File::Temp) 1 perl(HTTP::Date) 1 perl(HTTP::Status) 1 perl(IO::Socket::INET) 1 perl-libs 1 perl(List::Util) 1 perl(Parallel::Prefork) 1 perl(Plack) 1 perl(Plack::HTTPParser) 1 perl(Plack::TempBuffer) 1 perl(Plack::Util) 1 perl(POSIX) 1 perl(Server::Starter) 1 perl(Socket) 1 perl(Starlet::Server) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(Try::Tiny) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Starlet-0.32-2.fc45.noarch.rpm | sort | uniq -c 1 perl(Plack::Handler::Starlet) 1 perl(Starlet) = 0.32 1 perl-Starlet = 0.32-2.fc45 1 perl(Starlet::Server) Binary provides are Ok. $ rpmlint ./perl-Starlet* perl-Starlet.noarch: E: spelling-error ('prefork', '%description -l en_US') perl-Starlet.src: E: spelling-error ('prefork', '%description -l en_US') 2 packages and 1 specfiles checked; 2 errors, 0 warnings, 8 filtered, 2 badness; has taken 0.3 s Note: The spelling errors are false positives - prefork is a technical term. Rpmlint is ok. Please correct all 'FIX' items. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2497530 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497530%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
