https://bugzilla.redhat.com/show_bug.cgi?id=2432458
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #10 from Artur Frenszek-Iwicki <[email protected]> --- I think it'd be preferable to add "BuildRequires: make" and use the Makefile instead of handling pkgconfig generation & testing manually. But still, this is not a "must", so - APPROVED. Package Review ============== Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 31275 bytes in 1 files. [x]: Package complies to the Packaging Guidelines. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. Note: successfully scratch-built in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=148152923 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gstr-devel-3.0.1-2.fc45.noarch.rpm gstr-3.0.1-2.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgfceahl5')] checks: 32, packages: 2 gstr.src: E: spelling-error ('grapheme', 'Summary(en_US) grapheme -> ephemera') gstr.src: E: spelling-error ('grapheme', '%description -l en_US grapheme -> ephemera') gstr-devel.noarch: E: spelling-error ('grapheme', '%description -l en_US grapheme -> ephemera') gstr-devel.noarch: E: spelling-error ('prev', '%description -l en_US prev -> perv, rev, pres') gstr-devel.noarch: E: spelling-error ('cpcount', '%description -l en_US cpcount -> count') gstr-devel.noarch: E: spelling-error ('cpwidth', '%description -l en_US cpwidth -> width') gstr-devel.noarch: E: spelling-error ('charwidth', '%description -l en_US charwidth -> char width, char-width, bandwidth') gstr-devel.noarch: E: spelling-error ('zerowidth', '%description -l en_US zerowidth -> zero width, zero-width, howitzer') gstr-devel.noarch: E: spelling-error ('unicode', '%description -l en_US unicode -> Unicode, uni code, uni-code') gstr-devel.noarch: E: spelling-error ('whitespace', '%description -l en_US whitespace -> white space, white-space, whites pace') gstr-devel.noarch: E: spelling-error ('cp', '%description -l en_US cp -> co, c, p') gstr-devel.noarch: E: spelling-error ('gstrlen', '%description -l en_US gstrlen -> strangle') gstr-devel.noarch: E: spelling-error ('gstrnlen', '%description -l en_US gstrnlen -> strangle') gstr-devel.noarch: E: spelling-error ('gstrwidth', '%description -l en_US gstrwidth -> widths') gstr-devel.noarch: E: spelling-error ('gstroff', '%description -l en_US gstroff -> stroganoff') gstr-devel.noarch: E: spelling-error ('gstrat', '%description -l en_US gstrat -> strata') gstr-devel.noarch: E: spelling-error ('gstrcmp', '%description -l en_US gstrcmp -> strumpet') gstr-devel.noarch: E: spelling-error ('gstrncmp', '%description -l en_US gstrncmp -> angstrom') gstr-devel.noarch: E: spelling-error ('gstrcasecmp', '%description -l en_US gstrcasecmp -> staircase') gstr-devel.noarch: E: spelling-error ('gstrncasecmp', '%description -l en_US gstrncasecmp ') gstr-devel.noarch: E: spelling-error ('gstrstartswith', '%description -l en_US gstrstartswith -> heartstrings') gstr-devel.noarch: E: spelling-error ('gstrendswith', '%description -l en_US gstrendswith -> trendsetting') gstr-devel.noarch: E: spelling-error ('gstrchr', '%description -l en_US gstrchr -> stretch') gstr-devel.noarch: E: spelling-error ('gstrrchr', '%description -l en_US gstrrchr -> stretch') gstr-devel.noarch: E: spelling-error ('gstrstr', '%description -l en_US gstrstr -> stressors') gstr-devel.noarch: E: spelling-error ('gstrrstr', '%description -l en_US gstrrstr -> songstress') gstr-devel.noarch: E: spelling-error ('gstrcasestr', '%description -l en_US gstrcasestr -> staircase') gstr-devel.noarch: E: spelling-error ('gstrcount', '%description -l en_US gstrcount -> undercount') gstr-devel.noarch: E: spelling-error ('gstrspn', '%description -l en_US gstrspn -> songstress') gstr-devel.noarch: E: spelling-error ('gstrcspn', '%description -l en_US gstrcspn -> songstress') gstr-devel.noarch: E: spelling-error ('gstrpbrk', '%description -l en_US gstrpbrk -> songstress') gstr-devel.noarch: E: spelling-error ('gstrsub', '%description -l en_US gstrsub -> substrata') gstr-devel.noarch: E: spelling-error ('gstrcpy', '%description -l en_US gstrcpy -> stroppy') gstr-devel.noarch: E: spelling-error ('gstrncpy', '%description -l en_US gstrncpy -> stringency') gstr-devel.noarch: E: spelling-error ('gstrcat', '%description -l en_US gstrcat -> castrate') gstr-devel.noarch: E: spelling-error ('gstrncat', '%description -l en_US gstrncat -> truncate') gstr-devel.noarch: E: spelling-error ('gstrdup', '%description -l en_US gstrdup -> stardust') gstr-devel.noarch: E: spelling-error ('gstrndup', '%description -l en_US gstrndup -> roundup') gstr-devel.noarch: E: spelling-error ('gstrsep', '%description -l en_US gstrsep -> strep') gstr-devel.noarch: E: spelling-error ('gstrltrim', '%description -l en_US gstrltrim -> trimmest') gstr-devel.noarch: E: spelling-error ('gstrrtrim', '%description -l en_US gstrrtrim -> trimmest') gstr-devel.noarch: E: spelling-error ('gstrtrim', '%description -l en_US gstrtrim -> trimmest') gstr-devel.noarch: E: spelling-error ('gstrrev', '%description -l en_US gstrrev -> songstress') gstr-devel.noarch: E: spelling-error ('gstrreplace', '%description -l en_US gstrreplace -> irreplaceable') gstr-devel.noarch: E: spelling-error ('gstrlower', '%description -l en_US gstrlower -> lowermost') gstr-devel.noarch: E: spelling-error ('gstrupper', '%description -l en_US gstrupper -> stripper') gstr-devel.noarch: E: spelling-error ('gstrellipsis', '%description -l en_US gstrellipsis -> ellipsis') gstr-devel.noarch: E: spelling-error ('gstrfill', '%description -l en_US gstrfill -> fillings') gstr-devel.noarch: E: spelling-error ('gstrlpad', '%description -l en_US gstrlpad -> straddled') gstr-devel.noarch: E: spelling-error ('gstrrpad', '%description -l en_US gstrrpad -> gastropod') gstr-devel.noarch: E: spelling-error ('gstrpad', '%description -l en_US gstrpad -> gastropod') gstr-devel.noarch: E: spelling-error ('gstrwtrunc', '%description -l en_US gstrwtrunc -> truncheon') gstr-devel.noarch: E: spelling-error ('gstrwlpad', '%description -l en_US gstrwlpad ') gstr-devel.noarch: E: spelling-error ('gstrwrpad', '%description -l en_US gstrwrpad ') gstr-devel.noarch: E: spelling-error ('gstrwpad', '%description -l en_US gstrwpad -> gastropod') gstr-devel.noarch: E: spelling-error ('ascii', '%description -l en_US ascii -> ASCII') 2 packages and 0 specfiles checked; 56 errors, 0 warnings, 7 filtered, 56 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "gstr-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/deths74r/gstr/archive/v3.0.1/gstr-3.0.1.tar.gz : CHECKSUM(SHA256) this package : dc3058164ec372559a45ba74522f318e3c43199610cbb4c420e2af8828a261aa CHECKSUM(SHA256) upstream package : dc3058164ec372559a45ba74522f318e3c43199610cbb4c420e2af8828a261aa Requires -------- gstr-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config Provides -------- gstr-devel: gstr-devel gstr-static pkgconfig(gstr) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review --copr-build 10651057 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Haskell, Python, SugarActivity, Java, R, PHP, fonts, Perl, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c10 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
