https://bugzilla.redhat.com/show_bug.cgi?id=2493314
--- Comment #19 from UW_Linux <[email protected]> --- Thank you, I'll handle this. Some minor replies regarding upstream behaviors: - The Fortran module directory: It is fixed upstream, using `CMAKE_INSTALL_Fortran_MODULES` to decide where to place `.mod`. I can include the patch in the RPM repo temporarily until next version is out. - Source file in `/usr/include/libxs/`: it's the header-only mode dedicatedly designed by upstream. I don't know why they are needed either, but simply removing them will break `libxs_source.h`. Will need to make header-only mode optional, which will be part of CMake patch. - LIBXS_VERSION_RC: Yeah, need to discuss on providing a way to disable Git- and build-time-derived version metadata. That said, the version number should be unaffected since CMake also reads version from `VERSION` file in the tarball. - CMAKE_INSTALL_DOCDIR: My concern is, the upstream owner now installs `Makefile.inc` and its supporting scripts into `LIBXS_SHARE_DIR` in CMake... I don't know if this affects RPM workflow in the future versions, but it should be possible to only set the installation path of docs to `CMAKE_INSTALL_DOCDIR`? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2493314 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202493314%23c19 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
