https://bugzilla.redhat.com/show_bug.cgi?id=2502712

Emmanuel Seyman <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Emmanuel Seyman <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
TODO: Since you've submitted the package for review, upstream has released
      several versions. Please update your package ASAP.

BuildRequires are ok
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST only appears from this version onwards.


$ rpm -qp --requires perl-CLI-Simple-2.0.14-1.fc45.noarch.rpm | sort | uniq -c
| grep -v rpmlib
      1 perl(Carp)
      1 perl(Class::Accessor::Fast)
      1 perl(CLI::Simple)
      1 perl(CLI::Simple::Constants)
      1 perl(CLI::Simple::DumpSpec)
      1 perl(CLI::Simple::Helpers)
      1 perl(CLI::Simple::Migrate)
      1 perl(CLI::Simple::Scaffold)
      1 perl(CLI::Simple::Shell)
      1 perl(CLI::Simple::Utils)
      1 perl(Cwd)
      1 perl(Data::Dumper)
      1 perl(English)
      1 perl(Exporter)
      1 perl(File::Basename)
      1 perl(File::ShareDir) >= 1.118
      1 perl(File::Which)
      1 perl(FindBin)
      1 perl(Getopt::Long)
      1 perl(JSON)
      1 perl-libs
      1 perl(List::Util)
      1 perl(Log::Log4perl)
      1 perl(Log::Log4perl::Level)
      1 perl(parent)
      1 perl(Pod::Usage)
      1 perl(Readonly)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 perl(YAML::Tiny) >= 1.76
      1 /usr/bin/bash
Binary requires are Ok.

$ rpm -qp --provides perl-CLI-Simple-2.0.14-1.fc45.noarch.rpm | sort | uniq -c
| grep -v rpmlib
      1 perl(CLI::Simple) = 2.0.14
      1 perl-CLI-Simple = 2.0.14-1.fc45
      1 perl(CLI::Simple::Constants) = 2.0.14
      1 perl(CLI::Simple::DumpSpec)
      1 perl(CLI::Simple::Helpers)
      1 perl(CLI::Simple::Migrate)
      1 perl(CLI::Simple::Modulino)
      1 perl(CLI::Simple::Scaffold)
      1 perl(CLI::Simple::Shell)
      1 perl(CLI::Simple::Utils) = 2.0.14
Binary provides are Ok.

$ rpmlint ./perl-CLI-Simple*
perl-CLI-Simple.noarch: E: spelling-error ('ol', '%description -l en_US ol ->
lo, pl, o')
perl-CLI-Simple.src: E: spelling-error ('ol', '%description -l en_US ol -> lo,
pl, o')
perl-CLI-Simple.noarch: W: no-manual-page-for-binary create-modulino
perl-CLI-Simple.noarch: W: dangling-relative-symlink
/usr/share/man/man3/cli-simple.3pm.gz ../CLI::Simple.3pm.gz
========== 2 packages and 1 specfiles checked; 2 errors, 2 warnings, 8
filtered, 2 badness; has taken 0.2 s ==========

The package is in line with Fedora and Perl packaging guide lines.
Please consider fixing the 'TODO' item.

Resolution:
Approved


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2502712

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202502712%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to