https://bugzilla.redhat.com/show_bug.cgi?id=2507604
Jonathan Wright <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flags| |fedora-review+ Status|NEW |POST --- Comment #1 from Jonathan Wright <[email protected]> --- Approved Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Affero General Public License v3.0", "BSD 2-Clause License". 71 files have unknown license. Detailed output of licensecheck in /home/jonathan/fedora- review/2507604-offpunk/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.15/site- packages/__pycache__, /usr/lib/python3.15, /usr/lib/python3.15/site- packages [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: offpunk-3.2-1.fc45.noarch.rpm offpunk-3.2-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpr3afbr92')] checks: 32, packages: 2 offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/cert_migration.py 644 /usr/bin/env python3 offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/netcache_migration.py 644 /usr/bin/env python3 offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/offthemes.py 644 /bin/python offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/offutils.py 644 /bin/python offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/unmerdify.py 644 /usr/bin/env python3 offpunk.noarch: W: no-manual-page-for-binary ansicat offpunk.noarch: W: no-manual-page-for-binary netcache offpunk.noarch: W: no-manual-page-for-binary offpunk offpunk.noarch: W: no-manual-page-for-binary openk offpunk.noarch: W: no-manual-page-for-binary unmerdify offpunk.noarch: W: no-manual-page-for-binary xkcdpunk offpunk.noarch: W: no-documentation 2 packages and 0 specfiles checked; 5 errors, 7 warnings, 7 filtered, 5 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/cert_migration.py 644 /usr/bin/env python3 offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/netcache_migration.py 644 /usr/bin/env python3 offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/offthemes.py 644 /bin/python offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/offutils.py 644 /bin/python offpunk.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/unmerdify.py 644 /usr/bin/env python3 offpunk.noarch: W: no-manual-page-for-binary ansicat offpunk.noarch: W: no-manual-page-for-binary netcache offpunk.noarch: W: no-manual-page-for-binary offpunk offpunk.noarch: W: no-manual-page-for-binary openk offpunk.noarch: W: no-manual-page-for-binary unmerdify offpunk.noarch: W: no-manual-page-for-binary xkcdpunk offpunk.noarch: W: no-documentation 1 packages and 0 specfiles checked; 5 errors, 7 warnings, 3 filtered, 5 badness; has taken 0.0 s Source checksums ---------------- https://git.sr.ht/~lioploum/offpunk/archive/v3.2.tar.gz#/offpunk-3.2.tar.gz : CHECKSUM(SHA256) this package : a782030e23e37747d31f1f46fd90fe1d7cb9746235825ffda4c9b2f6f96ff442 CHECKSUM(SHA256) upstream package : a782030e23e37747d31f1f46fd90fe1d7cb9746235825ffda4c9b2f6f96ff442 Requires -------- offpunk (rpmlib, GLIBC filtered): /usr/bin/python3 file less python(abi) xdg-utils Provides -------- offpunk: offpunk python3.15dist(offpunk) python3dist(offpunk) Diff spec file in url and in SRPM --------------------------------- --- /home/jonathan/fedora-review/2507604-offpunk/srpm/offpunk.spec 2026-07-27 14:42:45.306346585 -0500 +++ /home/jonathan/fedora-review/2507604-offpunk/srpm-unpacked/offpunk.spec 2026-07-26 19:00:00.000000000 -0500 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # PyPI is still on 3.1 %bcond srht_source 1 @@ -23,4 +33,5 @@ BuildArch: noarch BuildRequires: python3-devel +# BuildRequires: python3dist(pytest) BuildRequires: gettext # needed for both pyproject_check_import and tests @@ -28,32 +39,11 @@ Requires: file Requires: less -Requires: python3dist(cryptography) Requires: xdg-utils -# web dependencies Recommends: chafa -Recommends: curl -Recommends: python3dist(beautifulsoup4) -Recommends: python3dist(feedparser) -Recommends: python3dist(readability) -# gopher dependencies -Recommends: python3dist(charset-normalizer) -# nice to have -Recommends: python3dist(setproctitle) -Recommends: wl-clipboard - %global _description %{expand: -Offpunk is a command-line offline-first web browser for your terminal. -Every content you visit is cached and can be visited later while offline. If you -try to visit a content not available in your cache, it will be marked to be -downloaded later. Offpunk allows you to synchronise you computer once every -hour, day or week and work offline without being interrupted. - -Offpunk transparently browse http/https/gemini/gopher/spartan/finger links. In -your terminal, it will nicely display HTML, Gemtext, Gophermap, txt, RSS, Atom -and even pictures. You can subscribe to an RSS feed or to any page. Offpunk -merges the concept of browsing pages and subscribing to feeds.} +This is package 'offpunk' generated automatically by pyp2spec.} %description %_description @@ -98,3 +88,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Jul 27 2026 John Doe <[email protected]> - 3.2-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2507604 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: PHP, SugarActivity, fonts, R, C/C++, Java, Ocaml, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2507604 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202507604%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
