https://bugzilla.redhat.com/show_bug.cgi?id=2490735
--- Comment #5 from Miro Hrončok <[email protected]> --- Spec sanity: 1. Summary ends with a dot: "Python SDK for ACP clients and agents." rpmlint flags this as summary-ended-with-dot. Remove the trailing period. 2. Description line is too long (rpmlint description-line-too-long). The single-line %_description should be wrapped to fit within 79 characters. 3. Only %pyproject_check_import is used in %check, but upstream has a pytest test suite with tests in tests/, e.g. via %pytest --ignore tests/real_user 4. I do not understand the "Exclude extra logfire, hermes-agent does not rely on it." comment. If you choose not to *package* the logfire extra, it should be due to missing dependencies, and the comment should probably go elsewhere. 5. Version 0.9.0 is packaged, but 0.11.1 is the latest on PyPI. Consider updating. 6. Consider a Source URL that has the project name in the filename, e.g. https://github.com/agentclientprotocol/python-sdk/archive/%{version}/python-sdk-%{version}.tar.gz Otherwise, the package seems well-structured and follows the guidelines. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2490735 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202490735%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
