https://bugzilla.redhat.com/show_bug.cgi?id=2508529

Tom "spot" Callaway <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]



--- Comment #1 from Tom "spot" Callaway <[email protected]> ---
A few cleanups here: 

1. You should not need to hardcode a definition for the "autorelease" macro in
Fedora
2. Your "john doe" %changelog should be replaced with just:

%changelog
%autochangelog

3. The License tag is incorrect. The actual licensing here is much more
complex, see LICENSE.dependencies. We need to list the full license combination
set, which is:

License: ((MIT OR Apache-2.0) AND Unicode-3.0) AND Apache-2.0 AND (Apache-2.0
OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND
(BSD-2-Clause OR Apache-2.0 OR MIT) AND MIT AND Unicode-3.0

Everything else looks okay here. Show me a .spec file with those issues
addressed and I'll approve this package and sponsor the maintainer.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2508529

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202508529%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to