https://bugzilla.redhat.com/show_bug.cgi?id=2366696
--- Comment #22 from Artur Frenszek-Iwicki <[email protected]> --- > Please replace all uses of %{__cmake_builddir} with %{_vpath_builddir}. Done. > I opened https://github.com/quickjs-ng/quickjs/pull/1531; > please add a link to that PR in the spec file. Done. > You have incorrectly marked SECURITY.md as %license. Oops. Changed to %doc. > Consider packaging README.md as %doc in the -libs subpackage. Added. > Is it possible to at least get some information about failing tests? Added a comment. > The uploaded spec file and SRPM differ in the version in the SRPM Ugh, that's what I get for making unnecessary style changes. Sorry about that. > The first %cmake invocation is in %prep rather than %build. > Please move it back to %build, or put it in a %conf section. Moved back to %build. > You need to mark %{_docdir}/quickjs/ as documentation (%doc). Done. Also renamed the directory from quickjs to quickjs-ng. > The contents are just 10 relatively small examples for developers Chucked in some documentation from the docs/ directory. While these are meant to be built to HTML using docusaurus, they are still perfectly readable markdown files. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make Eh, why not. Added a comment to emphasise the deliberate mixing cmake and make. > https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval Sure, added. > Please add a comment to the spec file mentioning the licenses involved > in the test262 source archive Done. re/man pages, I took some time to write man pages based on the --help output and submitted them upstream. These have been accepted and are now part of the standard install. Also, updated to v0.16.0. spec: https://suve.fedorapeople.org/review/quickjs-ng-0.16.0-1/quickjs-ng.spec srpm: https://suve.fedorapeople.org/review/quickjs-ng-0.16.0-1/quickjs-ng-0.16.0-1.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=148517746 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2366696 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202366696%23c22 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
