https://bugzilla.redhat.com/show_bug.cgi?id=2509218
--- Comment #1 from Cole Robinson <[email protected]> --- rust package but not using rust2rpm so we are off the beaten path here, but the structure looks ok to me. builds and installs fine on rawhide. Only other examples of cryptsetup plugins I found in fedora come from systemd-udev and cryptsetup-ssh-token. But doesn't look like there's anything special besides dropping an .so, that this seems fine. Issues: + License: needs to contain the condensed output of LICENSE.dependencies, basically what was done for previous rust crate review. Can use `license-validate` to double check your License: string. + use %{__cc} instead of gcc + big one that needs testing: the default fedora build flags aren't used. see `rpm --eval '%{build_cflags}'` and `rpm --eval '%{build_ldflags}'`. Possibly some of those will conflict with the special flags you need for building the .so, but append additional options as needed to get the output working. best IMO for packaging would fix the Makefile up to be well behaved, so that this just works: %set_build_flags %make_build YOUR_TARGET_NAME (and possible %make_install for the %install section too) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2509218 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202509218%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
