https://bugzilla.redhat.com/show_bug.cgi?id=2509757
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <[email protected]> --- URL and Source addressed are Ok. Source0 archive (SHA-512: 326891a232cacaf31a1789cdb27fb90602b97c90091ba9a5a519fc8be6512ea36239b45a39cecfdd6ac0690817e5953581f42043a5774229ee76aa407c2be28e) is original. Ok. License verified from README, LICENSE, dist.ini, lib/Thread/SigMask.pm. Ok. XS code found, fullarch BuildArch is Ok. Summary verified from lib/Thread/SigMask.pm. Ok. Description verified from lib/Thread/SigMask.pm. Ok. TODO: Move 'perl(ExtUtils::CBuilder)' build-dependency into 'build requirements' section. TODO: Move 'perl(blib)' build-dependency into 'test requirements' section. TODO: Unset AUTHOR_TESTING and RELEASE_TESTING environment variables in %check section to make the test more reproducible. TODO: Report upstream that Perl_croak() at lib/Thread/SigMask.xs:18 is missing a string argument: lib/Thread/SigMask.xs: In function ‘S_sv_to_sigset’: lib/Thread/SigMask.xs:18:34: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat=] 18 | Perl_croak(aTHX_ "%s is not of type POSIX::SigSet"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ All tests pass. Ok. $ rpmlint perl-Thread-SigMask.spec ../SRPMS/perl-Thread-SigMask-0.004-43.fc45.src.rpm ../RPMS/x86_64/perl-Thread-SigMask-* ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 perl-Thread-SigMask.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Thread/SigMask/SigMask.bs perl-Thread-SigMask.x86_64: E: spelling-error ('perls', '%description -l en_US perls -> Perls, peels, perks') perl-Thread-SigMask.x86_64: E: spelling-error ('sigprocmask', '%description -l en_US sigprocmask ') perl-Thread-SigMask.src: E: spelling-error ('perls', '%description -l en_US perls -> Perls, peels, perks') perl-Thread-SigMask.src: E: spelling-error ('sigprocmask', '%description -l en_US sigprocmask ') perl-Thread-SigMask.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Thread-SigMask/LICENSE == 4 packages and 1 specfiles checked; 6 errors, 0 warnings, 13 filtered, 6 badness; has taken 0.6 s == FIX: Remove empty *.bs files in %install phase with "find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -delete" command and build-require 'findutils'. $ rpm -q -lv -p ../RPMS/x86_64/perl-Thread-SigMask-0.004-43.fc45.x86_64.rpm drwxr-xr-x 2 root root 0 Jul 29 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 29 02:00 /usr/lib/.build-id/f8 lrwxrwxrwx 1 root root 70 Jul 29 02:00 /usr/lib/.build-id/f8/7a37efe1784890345b4ab11d3bf5e05722cdc6 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Thread/SigMask/SigMask.so drwxr-xr-x 2 root root 0 Jul 29 02:00 /usr/lib64/perl5/vendor_perl/Thread -rw-r--r-- 1 root root 2047 Jul 29 02:00 /usr/lib64/perl5/vendor_perl/Thread/SigMask.pm drwxr-xr-x 2 root root 0 Jul 29 02:00 /usr/lib64/perl5/vendor_perl/auto/Thread drwxr-xr-x 2 root root 0 Jul 29 02:00 /usr/lib64/perl5/vendor_perl/auto/Thread/SigMask -rw-r--r-- 1 root root 0 Jul 29 02:00 /usr/lib64/perl5/vendor_perl/auto/Thread/SigMask/SigMask.bs -rwxr-xr-x 1 root root 11088 Jul 29 02:00 /usr/lib64/perl5/vendor_perl/auto/Thread/SigMask/SigMask.so drwxr-xr-x 2 root root 0 Jul 29 02:00 /usr/share/doc/perl-Thread-SigMask -rw-r--r-- 1 root root 498 Mar 6 2014 /usr/share/doc/perl-Thread-SigMask/Changes -rw-r--r-- 1 root root 370 Mar 6 2014 /usr/share/doc/perl-Thread-SigMask/README drwxr-xr-x 2 root root 0 Jul 29 02:00 /usr/share/licenses/perl-Thread-SigMask -rw-r--r-- 1 root root 18356 Mar 6 2014 /usr/share/licenses/perl-Thread-SigMask/LICENSE -rw-r--r-- 1 root root 1769 Jul 29 02:00 /usr/share/man/man3/Thread::SigMask.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Thread-SigMask-0.004-43.fc45.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.32)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 perl(:MODULE_COMPAT_5.44.0) 1 perl(Exporter) >= 5.57 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Thread-SigMask-0.004-43.fc45.x86_64.rpm | sort -f | uniq -c 1 perl(Thread::SigMask) = 0.004 1 perl-Thread-SigMask = 0.004-43.fc45 1 perl-Thread-SigMask(x86-64) = 0.004-43.fc45 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Thread-SigMask-0.004-43.fc45.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora Rawhdide (https://koji.fedoraproject.org/koji/taskinfo?taskID=148653247). Ok. Please correct the FIX item and consider fixing the TODO items before building this package. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2509757 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202509757%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
