https://bugzilla.redhat.com/show_bug.cgi?id=2491129



--- Comment #4 from Miro HronĨok <[email protected]> ---
ISSUES

1. Summary ends with a dot: "A Python package which creates simple interactive
menus on the command line." -- rpmlint warning summary-ended-with-dot. Remove
the trailing period from Summary.

2. Description is just the same line as in summary. Consider extending it.

3. %pyproject_save_files -l is combined with explicit %license LICENSE in
%files. This results in the LICENSE being shipped twice (as %license in both
/usr/lib/python3.15/site-packages/simple_term_menu-1.6.6.dist-info/licenses/LICENSE
and /usr/share/licenses/python3-simple-term-menu/LICENSE). Per the guidelines,
-l is meant for when %license is NOT manually listed. Please keep
%pyproject_save_files -l and remove the explicit %license LICENSE from %files.

4. rpmlint non-executable-script:
/usr/lib/python3.15/site-packages/simple_term_menu.py has a #!/usr/bin/env
python3 shebang but 644 permissions. This is an importable module, not a script
(the CLI entry point is the separate /usr/bin/simple-term-menu). Please fix
this upstream and possibly remove the
shebang from the installed module in %prep in the meantime, e.g. via something
like: sed -i '1{/^#!/d}' simple_term_menu.py

rpmlint output

python-simple-term-menu.src: W: summary-ended-with-dot
python3-simple-term-menu.noarch: W: summary-ended-with-dot
python3-simple-term-menu.noarch: E: non-executable-script
/usr/lib/python3.15/site-packages/simple_term_menu.py 644 /usr/bin/env python3
python3-simple-term-menu.noarch: W: no-manual-page-for-binary simple-term-menu


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2491129

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202491129%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to