https://bugzilla.redhat.com/show_bug.cgi?id=2510919

Cristian Le <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]



--- Comment #5 from Cristian Le <[email protected]> ---
Next time please indicate that this is an unretirement in the description
(although if we are lucky we will have a whole new process for the next time :)
).

I like the
> Provides: %{name}-mpi-devel = %{version}-%{release}

idea, but we might want to do something different with the mpi-5 ABI idea that
is floating around. We can work on a change proposal together for that if you
feel up for it? For now, let's just keep it the same like the other mpi
packages.

Please do the `%conf` split here. It is especially useful for mpi packages

The prep steps look super sus. You should be able to do the `%configure` and
`%make_build` in specific subdirectories similar to the cmake ones.

Can you check if using `autoreconf` is possible for this package?

Will need to do another license check, I really doubt that license tag is
complete.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2510919

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202510919%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to