https://bugzilla.redhat.com/show_bug.cgi?id=2511009



--- Comment #5 from Ulrich Schwickerath <[email protected]> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* Apache License", "Apache License 2.0". 51 files have
     unknown license. Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/python-magnumclient/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.15/site-
     packages, /usr/lib/python3.15
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 1564 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[-]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-magnumclient
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: python3-magnumclient-4.11.0-1.fc45.noarch.rpm
          python-magnumclient-doc-4.11.0-1.fc45.noarch.rpm
          python-magnumclient-4.11.0-1.fc45.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp3lwe9uo8')]
checks: 32, packages: 3

python-magnumclient.src: E: spelling-error ('mangumclient', '%description -l
en_US mangumclient -> management')
python-magnumclient-doc.noarch: E: spelling-error ('mangumclient',
'%description -l en_US mangumclient -> management')
python3-magnumclient.noarch: E: spelling-error ('mangumclient', '%description
-l en_US mangumclient -> management')
python3-magnumclient.noarch: W: no-manual-page-for-binary magnum
python-magnumclient-doc.noarch: W: files-duplicate
/usr/share/doc/python-magnumclient-doc/html/_static/images/openstack-logo-full.png
/usr/share/doc/python-magnumclient-doc/html/_static/images/logo-full.png
python-magnumclient-doc.noarch: W: files-duplicate
/usr/share/doc/python-magnumclient-doc/html/_static/images/openstack-logo-full.svg
/usr/share/doc/python-magnumclient-doc/html/_static/images/logo-full.svg
python-magnumclient-doc.noarch: W: files-duplicate
/usr/share/doc/python-magnumclient-doc/html/_static/images/openstack-logo-vert.png
/usr/share/doc/python-magnumclient-doc/html/_static/images/logo-vert.png
python-magnumclient-doc.noarch: W: files-duplicate
/usr/share/doc/python-magnumclient-doc/html/_static/images/openstack-logo-vert.svg
/usr/share/doc/python-magnumclient-doc/html/_static/images/logo-vert.svg
 3 packages and 0 specfiles checked; 3 errors, 5 warnings, 61 filtered, 3
badness; has taken 0.4 s 




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "python-magnumclient-doc".
(none): E: there is no installed rpm "python3-magnumclient".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts
============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0
badness; has taken 0.0 s 



Source checksums
----------------
https://tarballs.openstack.org/python-magnumclient/python_magnumclient-4.11.0.tar.gz
:
  CHECKSUM(SHA256) this package     :
d90cce71d4c327ada4c31fbd040d3e5df2c1f0c06cdd9e44d7715c0b5978c2f1
  CHECKSUM(SHA256) upstream package :
d90cce71d4c327ada4c31fbd040d3e5df2c1f0c06cdd9e44d7715c0b5978c2f1
https://tarballs.openstack.org/python-magnumclient/python_magnumclient-4.11.0.tar.gz.asc
:
  CHECKSUM(SHA256) this package     :
4307cabfc898b6e55a524b49a78f8cef10e1d558771a6413a3ed9b7d3aab0d9f
  CHECKSUM(SHA256) upstream package :
4307cabfc898b6e55a524b49a78f8cef10e1d558771a6413a3ed9b7d3aab0d9f
https://releases.openstack.org/_static/0x30566c450e41d7c91e442dfb231f942f608ddeff.txt
:
  CHECKSUM(SHA256) this package     :
0f7901e358e78067604188563264589ee3a53f2369379a9b6310ab698af10fc9
  CHECKSUM(SHA256) upstream package :
0f7901e358e78067604188563264589ee3a53f2369379a9b6310ab698af10fc9


Requires
--------
python3-magnumclient (rpmlib, GLIBC filtered):
    ((python3.15dist(oslo-serialization) < 2.19.1 or
python3.15dist(oslo-serialization) > 2.19.1) with
python3.15dist(oslo-serialization) >= 2.18)
    ((python3.15dist(pbr) < 2.1 or python3.15dist(pbr) > 2.1) with
python3.15dist(pbr) >= 2)
    /usr/bin/python3
    python(abi)
    python3.15dist(cryptography)
    python3.15dist(decorator)
    python3.15dist(keystoneauth1)
    python3.15dist(openstacksdk)
    python3.15dist(osc-lib)
    python3.15dist(oslo-i18n)
    python3.15dist(oslo-log)
    python3.15dist(oslo-utils)
    python3.15dist(prettytable)
    python3.15dist(requests)
    python3.15dist(stevedore)

python-magnumclient-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-magnumclient:
    python-magnumclient
    python3-magnumclient
    python3.15-magnumclient
    python3.15dist(python-magnumclient)
    python3dist(python-magnumclient)

python-magnumclient-doc:
    python-magnumclient-doc



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
python-magnumclient --mock-config
/var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: SugarActivity, C/C++, R, Java, Perl, PHP, Ocaml, fonts,
Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2511009

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202511009%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to