https://bugzilla.redhat.com/show_bug.cgi?id=2512033

Emmanuel Seyman <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Emmanuel Seyman <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
TODO: Upstream now includes the text of the program license in the tarball.
Please update your package and use the included license files instead of your
own.

URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: You use %{_fixperms} but do not have 'coreutils' as a BR ('%{_fixperms}'
calls chmod). Please consider including it.
FIX: 'NO_PACKLIST' and 'NO_PERLLOCAL' only became available with
ExtUtils::MakeMaker 6.76 and later versions. Please add that version to the BR.

Binary requires are Ok.
Binary provides are Ok.

$ rpmlint perl-Net-HTTPS-NB*

perl-Net-HTTPS-NB.noarch: E: env-script-interpreter
/usr/share/doc/perl-Net-HTTPS-NB/google_multi.pl /usr/bin/env perl

TDOO: Consider changing the shebang in google_multi.pl to point to
/usr/bin/perl

The package is in line with Fedora and Perl packaging guide lines.
Please correct the FIX items and consider fixing the 'TODO' items.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2512033

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202512033%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to