https://bugzilla.redhat.com/show_bug.cgi?id=2496419
--- Comment #13 from Parag Nemade <[email protected]> --- (In reply to Jens Petersen from comment #12) > I think overall it looks quite good, but a few more comments below > > (In reply to Fedora Review Service from comment #11) > > Found issues: > > > > - License file LICENSE-dict is not marked as %license > > I noticed a few license files are listed in doc= fields instead of > license_file. Fixed this. > > My remaining suggestion would be to simplify the language table's fields, > since there is quite a lot of redundant metadata around the lang/locales. > I think a `dir` field (or `subdir` if you prefer) would help a lot for each > language. Fixed this. > > Also good to review the %install section and see if anything can be > simplified there. Removed all aliases but can't remove renaming of dictionary files to match with glibc locale names. > > Can you confirm if you used licensecheck to cross-check the license tags? I have tried my best to check all these license tags manually. Please check this updated package and provide your review comments. Spec URL: https://pnemade.fedorapeople.org/libreoffice-dictionaries.spec SRPM URL: https://pnemade.fedorapeople.org/libreoffice-dictionaries-26.8.0.2-1.fc44.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2496419 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202496419%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
