https://bugzilla.redhat.com/show_bug.cgi?id=2502711
Emmanuel Seyman <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Emmanuel Seyman <[email protected]> --- URL and Source0 are ok Source0 archive (SHA-224:3dc98c697e737391b8570ef2440f825f5a2cf268dc6b9ebbe8843ecb) is original. Ok. License verified from lib/Text/Markdown/Discount.pm is ok. TODO: Upstream should be contacted to let them know that their LICENSE file is out of date (the FSF no longer has a physical address). Summary is ok. Description is ok BuildRequires are ok FIX: Add 'coreutils' to BRs (needed for %{_fixperms}) FIX: Add 'findutils' to BRs (needed for find) FIX: Add 'sed' to BRs (needed for sed) $ rpm -qp --requires perl-Text-Markdown-Discount-0.18-1.* | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libmarkdown.so.2()(64bit) 1 perl(Exporter) 1 perl-libs 1 perl(:MODULE_COMPAT_5.44.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.1 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) 1 perl(Text::Markdown::Discount) = 0.18 1 perl-Text-Markdown-Discount = 0.18-1.fc45 1 perl-Text-Markdown-Discount(x86-64) = 0.18-1.fc45 Binary requires are Ok. $ rpm -qp --provides perl-Text-Markdown-Discount-0.18-1.*| sort | uniq -c 1 perl(Text::Markdown::Discount) = 0.18 1 perl-Text-Markdown-Discount = 0.18-1.fc45 1 perl-Text-Markdown-Discount(x86-64) = 0.18-1.fc45 Binary provides are Ok. $ rpmlint perl-Text-Markdown-Discount* perl-Text-Markdown-Discount.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Text-Markdown-Discount/LICENSE Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct 'FIX' items and consider fixing the 'TODO' item. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2502711 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202502711%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
