https://bugzilla.redhat.com/show_bug.cgi?id=2512063

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]
                 CC|                            |[email protected]



--- Comment #1 from Fabio Valentini <[email protected]> ---
A few comments:

- Changing the "default" feature flags is considered a breaking change
(compared to upstream / crates.io).
  I would usually recommend *not* to patch the "default" feature flags, and
instead set feature flags for lapin in dependent packages accordingly.
- There are a few other changes that aren't documented / explained (dropped
features for "codegen", "codegen-internal", "native-tls", "rustls",
"rustls--aws_lc_rs", "rustls--ring", "rustls-native-certs",
"rustls-platform-verifier", "rustls-webpki-roots", "vendored-openssl").

All rustls-related features could stay enabled as far as I can tell (except
rustls--aws_lc_rs), dropping "vendored-openssl" makes sense, but "codegen*"
flags aren't obvious why they're dropped.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2512063

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202512063%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to