https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #14 from Neal Gompa <[email protected]> ---
This package has a few errors:

> Source0:        %{url}/archive/v%{version}.tar.gz

This should be "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"

> %autosetup

This should be "%autosetup -C"

> %build
> %meson \
>   -Dbacktrace=false
> %meson_build

This should be split into two, like so:

"""
%conf
%meson -Dbacktrace=false

%build
%meson_build
"""

From the template:

> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/icons/hicolor,
>      /usr/share/icons/hicolor/symbolic/apps,
>      /usr/share/icons/hicolor/scalable/apps,
>      /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor/symbolic

You're missing "Requires: hicolor-icon-theme".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2331268

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331268%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to