https://bugzilla.redhat.com/show_bug.cgi?id=2510919
--- Comment #20 from Cristian Le <[email protected]> --- - If you use autoreconf, might as well point the source to the git repo so that it is easier to navigate - There are few bundled codes to check - fdep (MIT), used only to create autotools, can skip from final license - ftimings (LGPL-3.0-or-later), missing `bundled` provides - src/shipped_srcs/* (MIT), no idea if it's used or not, but would need `bundled` - src/shipped_srcs/OPENCCL_TESTS has unknown providence, please ask about it - Are there discussions about upstreaming the patches? - `autoreconf` should be in %conf section - The flags overload is iffy, at least make a comment on why those choices - The x86_64 flags make this compatible only with x86_64-v3 [1]. This is a good case for looking on how can we distribute arch optimized libraries with `glibc-hwcaps`, and I even got recommended to talk with Florian about this. For now can we skip those, and investigate that together? - Are there scenarios where you want non-openmp version? Ideally both the openmp and mpi parallelization are configurable by the consumer or even the user. Can you check if at least the openmp one is/can be configurable? - Could you raise an issue with upstream about making the tests be runnable against a pre-installed elpa? Not a blocker here, but upstream should know that this would help us a lot with the build time and test navigability etc. - %ldconfig_scriplets are no-op (not actual no-op, but without RPATHs, it does nothing), please remove - Is there confirmation that the project is meant to be licensed under LGPL-3.0-only? BTW, years ago when I was in contact with them, they were open to migrate the build system to CMake. Would definitely help with a lot of complications that I can see from a mile away, but the m4 macros are daunting. [1]: https://en.wikipedia.org/wiki/X86-64 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2510919 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202510919%23c20 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
