https://bugzilla.redhat.com/show_bug.cgi?id=2516182
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |[email protected] Assignee|[email protected] |[email protected] Status|NEW |POST --- Comment #2 from Fabio Valentini <[email protected]> --- Package was generated with rust2rpm, simplifying the review. This is almost 100% boilerplate and a very small library (though quite old, with the last release having been in 2019 and no git activity since). I would recommend not to make manual modifications that cannot be encoded in rust2rpm.toml config file (like adding the "VCS" tag), but if you want to keep manually adding this every time you have to re-run rust2rpm in the future, you are free to do so. It might be nice to drop the files that are unused for build / packaging purposes (appveyor.yml, bulk.yaml, vagga.yaml, .travis.yml), but they don't *hurt* when included in the built package - see "package" / "exclude-crate-files" docs in "man rust2rpm.toml". ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2516182 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202516182%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
