https://bugzilla.redhat.com/show_bug.cgi?id=2521255
Bug ID: 2521255
Summary: Review Request: pva-base - A personal voice assistant
using vosk
Product: Fedora
Version: rawhide
URL: https://github.com/Cyborgscode/Personal-Voice-Assisten
t/
OS: Linux
Status: NEW
Component: Package Review
Keywords: RFE
Severity: low
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Target Milestone: ---
Classification: Fedora
Build:
https://copr.fedorainfracloud.org/coprs/mschwarz/pva/build/10889784/
Release:
https://download.copr.fedorainfracloud.org/results/mschwarz/pva/fedora-rawhide-x86_64/10889784-pva-base/
Licenses: MIT and APACHE 2
- possible issues:
ARCH should be changed to "noarch", because it's java
subpackages are shown, but somehow "gone lost" in copr !?!?
- Subpackages (for now)
https://copr.fedorainfracloud.org/coprs/mschwarz/pva/package/vosk-model-large-de/
https://copr.fedorainfracloud.org/coprs/mschwarz/pva/package/vosk-model-small-de/
https://copr.fedorainfracloud.org/coprs/mschwarz/pva/package/vosk-model-small-en-us/
a review request for each subpackage would be unnecessary, as they all are the
same composit:
it's just a bunch of data files, license and a config file:
=================================== Contents
===================================
-rw-r--r-- 1 root root 40 Mar 10 01:00
./etc/pva/conf.d/21-model-german-small.conf
drwxr-xr-x 1 root root 0 Mar 10 01:00
./usr/share/licenses/vosk-model-small-de
-rw-r--r-- 1 root root 543 Feb 20 22:35
./usr/share/licenses/vosk-model-small-de/AUTHOR
-rw-r--r-- 1 root root 11358 Dec 28 2025
./usr/share/licenses/vosk-model-small-de/LICENSE-2.0.txt
drwxr-xr-x 1 root root 0 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15
-rw-r--r-- 1 root root 10173 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/COPYING
-rw-r--r-- 1 root root 795 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/README
drwxr-xr-x 1 root root 0 Oct 7 2020
./usr/share/pva/vosk-model-small-de-0.15/am
-rw-r--r-- 1 root root 15749291 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/am/final.mdl
drwxr-xr-x 1 root root 0 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/conf
-rw-r--r-- 1 root root 108 Nov 26 2020
./usr/share/pva/vosk-model-small-de-0.15/conf/mfcc.conf
-rw-r--r-- 1 root root 289 Jun 19 2020
./usr/share/pva/vosk-model-small-de-0.15/conf/model.conf
drwxr-xr-x 1 root root 0 Oct 7 2020
./usr/share/pva/vosk-model-small-de-0.15/graph
-rw-r--r-- 1 root root 29472167 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/graph/Gr.fst
-rw-r--r-- 1 root root 41892842 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/graph/HCLr.fst
-rw-r--r-- 1 root root 42 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/graph/disambig_tid.int
drwxr-xr-x 1 root root 0 Oct 7 2020
./usr/share/pva/vosk-model-small-de-0.15/graph/phones
-rw-r--r-- 1 root root 4506 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/graph/phones/word_boundary.int
drwxr-xr-x 1 root root 0 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/ivector
-rw-r--r-- 1 root root 168048 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/ivector/final.dubm
-rw-r--r-- 1 root root 8288887 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/ivector/final.ie
-rw-r--r-- 1 root root 33775 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/ivector/final.mat
-rw-r--r-- 1 root root 803 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/ivector/global_cmvn.stats
-rw-r--r-- 1 root root 0 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/ivector/online_cmvn.conf
-rw-r--r-- 1 root root 35 Dec 3 2020
./usr/share/pva/vosk-model-small-de-0.15/ivector/splice.conf
There are 18 supported languages, with tons of "dialects" available and once
accepted, i will add them one bye one if requested.
the LARGE files are not easy to build in copr.. I needed a lot of tricks due to
the immense size of the files. As they are not changing over time, a way to
reuse them for each fedora release would be a smart move.
------------ REVIEW TEMPLATE
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
- Packages have proper BuildRequires/Requires on javapackages-tools
(jpackage-utils)
- Javadoc documentation files are generated and included in -javadoc
subpackage
Note: No javadoc subpackage present. Note: Javadocs are optional for
Fedora versions >= 21
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Java/#_pre_built_dependencies
===== MUST items =====
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT License", "Unknown or generated", "*No copyright* Apache
License 2.0 and/or GNU Lesser General Public License v2.1 or later",
"*No copyright* Apache License 2.0". 176 files have unknown license.
Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/pva-
base/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 50861 bytes in 18 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Maven:
[ ]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
===== SHOULD items =====
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
Java:
[ ]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
Rpmlint
-------
Checking: pva-base-0^20260821git389b9a3-1.fc43.noarch.rpm
pva-base-0^20260821git389b9a3-1.fc43.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpwcv8jhjt')]
checks: 32, packages: 2
pva-base.noarch: W: non-conffile-in-etc /etc/pva/conf.d/README.md
pva-base.noarch: W: no-manual-page-for-binary ai.py
pva-base.noarch: W: no-manual-page-for-binary chatgpt
pva-base.noarch: W: no-manual-page-for-binary f5tts
pva-base.noarch: W: no-manual-page-for-binary f5tts.py
pva-base.noarch: W: no-manual-page-for-binary gsay
pva-base.noarch: W: no-manual-page-for-binary msay
pva-base.noarch: W: no-manual-page-for-binary piper
pva-base.noarch: W: no-manual-page-for-binary psay
pva-base.noarch: W: no-manual-page-for-binary qwen3tts
pva-base.noarch: W: no-manual-page-for-binary recall-pva
pva-base.noarch: W: no-manual-page-for-binary samsungtts
pva-base.noarch: W: no-manual-page-for-binary say
pva-base.spec: W: no-%check-section
pva-base.noarch: W: incoherent-version-in-changelog 0^20260326git096dda2
['0^20260821git389b9a3-1.fc43', '0^20260821git389b9a3-1']
pva-base.noarch: E: devel-dependency vosk-api-devel
2 packages and 0 specfiles checked; 1 errors, 15 warnings, 6 filtered, 1
badness; has taken 0.3 s
Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "pva-base".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0
badness; has taken 0.0 s
Source checksums
----------------
https://github.com/Cyborgscode/Personal-Voice-Assistent/archive/refs/heads/main.zip
:
CHECKSUM(SHA256) this package :
c32e55cfd07e054e98149387232094c331940c1cd9c5677d7646c8653ef931ee
CHECKSUM(SHA256) upstream package :
c32e55cfd07e054e98149387232094c331940c1cd9c5677d7646c8653ef931ee
Requires
--------
pva-base (rpmlib, GLIBC filtered):
/usr/bin/bash
/usr/bin/python3
config(pva-base)
curl
dbus-tools
espeak
ffmpeg
gtts
jakarta-activation
jakarta-activation1
jakarta-mail
jakarta-mail1
java-headless
jna
opencv-java
openssl
sox
vosk-api-devel
xdotool
Provides
--------
pva-base:
application()
application(PVA.desktop)
application(pva-shutdown.desktop)
config(pva-base)
pva-base
Jar and class files in source
-----------------------------
./pva-base-0_20260821git389b9a3-build/Personal-Voice-Assistent-main/lib/jna-5.18.1.jar
./pva-base-0_20260821git389b9a3-build/Personal-Voice-Assistent-main/lib/javax.mail-1.6.2.jar
./pva-base-0_20260821git389b9a3-build/Personal-Voice-Assistent-main/lib/javax.activation-1.2.0.jar
./pva-base-0_20260821git389b9a3-build/Personal-Voice-Assistent-main/lib/PLACEHOLDER-
sqlite-jdbc-3.51.1.0.jar
Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
pva-base --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-43-x86_64
Active plugins: Java, Shell-api, Generic
Disabled plugins: R, PHP, Perl, SugarActivity, C/C++, fonts, Ocaml, Haskell,
Python
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Reproducible: Always
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2521255
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202521255%23c0
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://forge.fedoraproject.org/infra/tickets/issues/new
