https://bugzilla.redhat.com/show_bug.cgi?id=2521257
Steve Cossette <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Steve Cossette <[email protected]> --- Some pre-review comments: 1- Please remove the version minimums on build requirements, not needed (And will become even more useless as time goes) 2- I assume the requires are qml requirements? If so, please use the qt6qml() requirements 3- %cmake_kf6 should be under the %conf section, before %build (Yes, that is new) 4- For the patches, can you give some information in comments as to what they are? Are they upstreamed patches? If so, please show a link to the MR(s). If not, please note a purpose for the patches. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2521257 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202521257%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
