https://bugzilla.redhat.com/show_bug.cgi?id=2467653
--- Comment #3 from Artur Frenszek-Iwicki <[email protected]> --- > BuildRequires: gcc-c++ > BuildRequires: kernel-headers You're missing a BR on "make"; it's not part of the default buildroot since Fedora 34. https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot > %package -n gnome-shell-extension-keyd > Summary: Gnome Shell Extension used by keyd to obtain active window > information. > Requires: gnome-shell < 50 This should probably require the main package, as well. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package Also, as the extension is just some JavaScript code + metadata, you can make it "BuildArch: noarch". > %install > install -Dm644 LICENSE -t "%{buildroot}/usr/share/licenses/keyd" You don't need install the file manually; "%license LICENSE" will handle it for you. > mkdir -p > %{buildroot}%{_datadir}/gnome-shell/extensions/[email protected]/ > cp -r data/gnome-extension-45/* > %{buildroot}%{_datadir}/gnome-shell/extensions/[email protected]/ You should aim to preserve file timestamps. Use either "cp -pr" or "cp -a" here. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps > %check > [[ "$(bin/keyd --version)" = "keyd v%{version} ()" ]] Since %check runs after %install, might make sense to invoke %{buildroot}%{_bindir}/keyd here. > %files > %{_docdir}/%{name} This should be marked as %doc. > %files > %{_prefix}/lib/systemd/system/%{name}.service You could use the %{_unitdir} macro, instead. > %{_prefix}/lib/systemd/system/%{name}.service ...and %{_sysusersdir} here. > %files > %{_mandir}/man1/%{name}.1.gz > %{_mandir}/man1/%{name}-application-mapper.1.gz Do not assume that man pages will be gzipped. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2467653 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202467653%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
