https://bugzilla.redhat.com/show_bug.cgi?id=2519469
--- Comment #6 from Luca Albrecht <[email protected]> --- (In reply to Steve Traylen from comment #1) > Requires: rubygem-optimist > > * The indentation of this line is inconsistent with the other lines in the > header. > * Why is this line here at all ? `Requires` should normally auto computed > from the gemspec.... ? > > * I would say https://github.com/voxpupuli/hiera-eyaml/ was a better URL > than the rubygems one since that is the package's homepage. > > I can sponsor you but do you have some informal reviews of other packages > you could point me at or something? Thanks for the feedback, I have adjusted the spec file according to your feedback and triggered a new build on copr. I do not have any informal reviews I could point you to, however I can provide you with a bunch of other packages that I have packaged such as: - https://github.com/TeluTrix/personal-rpms/blob/main/obsidian/obsidian.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-gpgme/rubygem-gpgme.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-hiera-eyaml-gpg/rubygem-hiera-eyaml-gpg.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-optimist/rubygem-optimist.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-ruby-gpg/rubygem-ruby-gpg.spec Any feedback on those is obviously also much appreciated! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2519469 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202519469%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
