https://bugzilla.redhat.com/show_bug.cgi?id=2517899
--- Comment #2 from Jerry James <[email protected]> --- Thank you for the review! (In reply to Terje Rosten from comment #1) > [!]: License field in the package spec file matches the actual license. > License seems gp GPLv2 only to me. In the gap world, package metadata resides in PackageInfo.g. If you look in this package's PackageInfo.g, line 12 is: License := "GPL-2.0-or-later", > [!]: SourceX tarball generation or download is documented. > Note: Package contains tarball without URL, check comments > Please tell how source1 was generated I have added a comment explaining this. > [!]: %check is present and all tests pass. > Possible to add a sanity check of some sort? There actually is a %check section already, and it runs some tests. It's partially hidden behind the gap buildsystem macros, though, which may make it hard to notice. Take a look at the build log. You should see %check in the output, and after the GAP banner some text that starts like this: ``` testing: ~/build/BUILD/gap-pkg-perfgrp-1.0.0-build/BUILDROOT/usr/share/gap/pkg\ /perfgrp/tst/PerfectGroups.tst 1783 ms (360 ms GC) and 456MB allocated for PerfectGroups.tst ``` and ending like this: ``` ----------------------------------- total 38358 ms (1480 ms GC) and 2.42GB allocated 0 failures in 4 files #I No errors detected while testing ``` > gap-pkg-perfgrp.noarch: E: incorrect-fsf-address > /usr/share/licenses/gap-pkg-perfgrp/LICENSE > > > Please ping upstream about this issue. I have done so: https://github.com/gap-packages/perfgrp/issues/2 The URLs are the same as before: Spec URL: https://jjames.fedorapeople.org/gap-pkg-perfgrp/gap-pkg-perfgrp.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-perfgrp/gap-pkg-perfgrp-1.0.0-1.fc46.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2517899 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202517899%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
