https://bugzilla.redhat.com/show_bug.cgi?id=2494179
Miro Hrončok <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|ASSIGNED |POST --- Comment #6 from Miro Hrončok <[email protected]> --- 2 nitpicks: > # Remove shebang line from yarn.js > sed -i '1d' jupyter_builder/yarn.js Better guard that by checking if the first line actually has a shebang. In case it does not have it in a later version, we don't want to strip the first line. Something like 1{/^#!/d} --- The %generate_buildrequires section is the only section that is not separated by 2 empty lines. Neither is blocking. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2494179 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202494179%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
