https://bugzilla.redhat.com/show_bug.cgi?id=2521853
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #8 from Ben Beasley <[email protected]> --- Looking at the spec-file diff, rather than doing a full re-review: - You dropped the pypi_name macro indirection, which I suggested but is a matter of personal preference - You added comments for the manual Requires on cargo and git-core, which I thought wasn’t required but which is nevertheless helpful - You added a comment explaining why %cargo_generate_buildrequires needs -a and -t, which again isn’t required but is nice - You moved %pyproject_wheel to the end of %build, which fixed the unpackaged LICENSE.dependencies: $ rpm -qL -p ./results/python3-crate-ingredients-0.3.0-1.fc46.x86_64.rpm /usr/lib64/python3.15/site-packages/crate_ingredients-0.3.0.dist-info/licenses/LICENSE /usr/lib64/python3.15/site-packages/crate_ingredients-0.3.0.dist-info/licenses/LICENSE.dependencies - You added a comment explaining why tests can’t be run. All of these changes are useful and correct. The fedora-review template doesn’t flag any new potential issues, and there are no new rpmlint messages. Everything from the “Issues” section of the previous review has been dealt with. The package is therefore APPROVED. ---- The only thing I have left to say is that, since the linking issues for doctests are specific to ppc64le, you could do something like this: %check # run import check only: # * pytest unit tests require internet access # * cargo test fails to compile doctests for cdylib targets on ppc64le %pyproject_check_import %ifnarch %{power64} %cargo_test %endif That seemed to work fine in a quick scratch-build, https://koji.fedoraproject.org/koji/taskinfo?taskID=149489161. On the other hand, it looks like it didn’t actually find any doctests: test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2521853 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202521853%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
