https://bugzilla.redhat.com/show_bug.cgi?id=2521666
--- Comment #2 from Neal Gompa <[email protected]> --- Initial spec review: > Version: 0.1.339f590 This version doesn't make sense. It doesn't follow any real version or Fedora's snapshot versioning scheme. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_complex_versioning > Source0: %{name}-%{version}.tar.zst This needs to be a SourceURL. > %autosetup -p1 Unless you plan to support EPEL 9 or older, this can be "%autosetup -C -p1", so that you don't have to deal with the name-version inconsistency once you fix Version. > %config(noreplace) %{_sysconfdir}/grub.d/80_suse_btrfs_snapshot I'm pretty sure this is a script and not configuration, so this shouldn't be declared as a config file. (Yes, I know it's in the wrong place for that... GRUB needs to fix that someday...) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2521666 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202521666%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
