https://bugzilla.redhat.com/show_bug.cgi?id=2521657
--- Comment #3 from Neal Gompa <[email protected]> --- Initial spec review: > %dnl BuildRequires: bootloader-rpm-macros? This can be dropped. > %package volatile This should be "%package -n dracut-volatile-overlay" instead, since that's the name of the dracut module. All the other dracut modules need to be correctly subpackaged too, and the dependencies for the modules needs to be correctly specified (if needed). > %autosetup -p1 -n %{name}-%{commit} Unless you plan to support EPEL 9 or older, this can be just "%autosetup -C -p1" > %post [...] > %posttrans [...] These scriptlets are dangerous and make too many assumptions. They need to be dropped and reworked entirely. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2521657 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202521657%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
