https://bugzilla.redhat.com/show_bug.cgi?id=2519524

MartinKG <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|NEW                         |ASSIGNED



--- Comment #2 from MartinKG <[email protected]> ---
quick review:

I think the license type should be changed to:

License:        GPL-2.0-or-later AND GPL-2.0-only AND BSD-3-Clause AND MIT AND
Zlib

and the license brakedown should be added like this:

# main code is GPL-2.0-or-later:
# include/aac.h
# include/asf.h
# include/common.h
# include/dsdiff.h
# include/dsf.h
# include/flac.h
# include/id3.h
# include/mp3.h
# include/mp4.h
# include/ogf.h
# include/ogg.h
# include/opus.h
# include/wav.h
# include/wavpack.h
# src/aac.c
# src/asf.c
# src/common.c
# src/dsdiff.c
# src/dsf.c
# src/flac.c
# src/id3.c
# src/id3_compat.c
# src/id3_compat.gperf
# src/mp3.c
# src/mp4.c
# src/ogf.c
# src/ogg.c
# src/opus.c
# src/wav.c
# src/wavpack.c
#

# GPL-2.0-only:
# META.json
# COPYING
#

# BSD-3-Clause:
# include/mpc.h
# include/pstdint.h
# src/mpc.c
#

# MIT:
# include/ape.h
# src/ape.c
#

# Zlib:
# include/md5.h
# src/md5.c

and you should add

# Bundled libraries:
Provides:       bundled(musepack)

because Musepack is included in the following files:

# BSD-3-Clause:
# perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/mpc.h
# perl-Audio-Scan-1.13-build/Audio-Scan-1.13/include/pstdint.h
# perl-Audio-Scan-1.13-build/Audio-Scan-1.13/src/mpc.c


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2519524

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202519524%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to