https://bugzilla.redhat.com/show_bug.cgi?id=2512679
--- Comment #9 from Neal Gompa <[email protected]> --- Initial spec review: > %package qt5-ui > Summary: Qt5 UI for Electron > Requires: nodejs-electron%{_isa} = %{version}-%{release} This also needs a "Supplements: (nodejs-electron%{_isa} and qt5-qtbase-gui%{_isa})" stanza. (This also probably needs to be added to chromium too... > %package qt6-ui > Summary: Qt6 UI for Electron > Requires: nodejs-electron%{_isa} = %{version}-%{release} This also needs a "Supplements: (nodejs-electron%{_isa} and qt6-qtbase-gui%{_isa})" stanza. (This also probably needs to be added to chromium too... > cp /dev/stdin %{buildroot}%{_rpmmacrodir}/macros.electron <<"MACROEOF" This should be an extra source file rather than inlined like this. It's too fragile as-is. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2512679 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202512679%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
