https://bugzilla.redhat.com/show_bug.cgi?id=2513599
--- Comment #7 from Leo Sandoval <[email protected]> --- (In reply to Jerry James from comment #6) > After downloading the spec file and the srpm (it would have been better if > you had posted new Spec URL and SRPM URL lines): > > $ fedora-review -n grub2-confidential-computing -m fedora-rawhide-x86_64 > INFO: Processing local files: grub2-confidential-computing > INFO: Getting .spec and .srpm Urls from : Local files in > /home/jamesjer/review > INFO: --> SRPM url: > file:///home/jamesjer/review/grub2-confidential-computing-1-2.fc46.src.rpm > INFO: --> Spec url: > file:///home/jamesjer/review/grub2-confidential-computing.spec > INFO: Using review directory: > /home/jamesjer/review/review-grub2-confidential-computing > error: Unable to open > /home/jamesjer/rpmbuild/SOURCES/grub2-confidential-computing.macros: No such > file or directory > ERROR: "Can't parse specfile: can't parse specfile\n" (logs in > /home/jamesjer/.cache/fedora-review.log) > Exception ignored while flushing sys.stdout: > AttributeError: '_Null' object has no attribute 'flush' > $ fedora-review --copr-build > https://download.copr.fedorainfracloud.org/results/lsandova/grub2- > confidential-computing/srpm-builds/10932205/ -m fedora-rawhide-x86_64 > INFO: Processing COPR build: > https://download.copr.fedorainfracloud.org/results/lsandova/grub2- > confidential-computing/srpm-builds/10932205/ > ERROR: Copr build did not succeed, state=failed > > If you look at > https://download.copr.fedorainfracloud.org/results/lsandova/grub2- > confidential-computing/srpm-builds/10932205/builder-live.log.gz, you will > see the same problems with the COPR build. The issue is the first 2 lines > of the spec file: > > Source0: grub2-confidential-computing.macros > %include %{SOURCE0} > > That %include directive presumes that the macros file is available at SRPM > building time, which it isn't on my machine. Koji will have the same > problem. With the package in its current form, a koji build will fail the > SRPM building step. > > How is the actual build supposed to work? Note that there is no binary RPM > in that COPR directory, indicating that the build did not succeed. I have done several things so you can actually proceed - Avoided embedding the macros file (macros file was small, so no need to place globals in a separate file) otherwise we observe that failure (I was not aware of it) - place the spec and srpm in fedorapeople, so we do not need to deal with copr links https://lsandova.fedorapeople.org/grub2-confidential-computing/grub2-confidential-computing-1-2.fc46.src.rpm https://lsandova.fedorapeople.org/grub2-confidential-computing/grub2-confidential-computing.spec To double check, I have ran the `fedora-review` tool locally and seems to be working =====================8<==================== $ fedora-review -n grub2-confidential-computing -m fedora-rawhide-x86_64 INFO: Processing local files: grub2-confidential-computing INFO: Getting .spec and .srpm Urls from : Local files in /tmp/tmp.URhkaAYTG3 INFO: --> SRPM url: file:///tmp/tmp.URhkaAYTG3/grub2-confidential-computing-1-2.fc46.src.rpm INFO: --> Spec url: file:///tmp/tmp.URhkaAYTG3/grub2-confidential-computing.spec INFO: Using review directory: /tmp/tmp.URhkaAYTG3/review-grub2-confidential-computing INFO: No upstream for (Source0): sbat.csv.in INFO: No upstream for (Source1): grub_prefix_embedded.cfg INFO: No upstream for (Source2): grub.cfg INFO: Running checks and generating report INFO: Results and/or logs in: /tmp/tmp.URhkaAYTG3/review-grub2-confidential-computing/results INFO: Reading configuration from /etc/mock/site-defaults.cfg INFO: Reading configuration from /etc/mock/chroot-aliases.cfg INFO: Reading configuration from /etc/mock/fedora-rawhide-x86_64.cfg INFO: Build completed INFO: Installing built package(s) Removed 0 files, 0 directories (total of 0 B). 0 errors occurred. INFO: Active plugins: Shell-api, Generic Updating and loading repositories: Repositories loaded. Updating and loading repositories: Repositories loaded. INFO: ExclusiveArch dependency checking disabled, enable with EXARCH flag Review template in: /tmp/tmp.URhkaAYTG3/review-grub2-confidential-computing/review.txt fedora-review is automated tool, but *YOU* are responsible for manually reviewing the results and finishing the review. Do not just copy-paste the results without understanding them. =====================8<==================== One more thing: The copr build is here in case you need it https://copr.fedorainfracloud.org/coprs/lsandova/grub2-confidential-computing/build/10940681/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2513599 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202513599%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
