https://bugzilla.redhat.com/show_bug.cgi?id=2529191
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <[email protected]> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 6e6f24917c2cdc13acfd66823e2377f283f2b94c729f9a29e789f24534444358a82b57c6a0bd52214339764c9c9d37d3b75ec4c7bdc75b3c9693a6065912aced) is original. Ok. Summary verified from lib/Params/SomeUtil.pm. Ok. Description verified from lib/Params/SomeUtil.pm. Ok. License verified in: README.md, lib/Params/SomeUtil.pm, Makefile.PL, LICENSE, README. Ok. XS code found, no noarch BuildArch is Ok. TODO: Change minimal perl(Test::More) version to '>= 0.87' (Makefile.PL:82). TODO: Constrain perl(Scalar::Util) dependency with '>= 1.18' (Makefile.PL:78). TODO: Constrain perl version with 'perl(:VERSION) >= 5.5.3' (Makefile.PL:3). TODO: Unset PERL_PARAMS_UTIL_PP and PERL_PARAMS_SOMEUTIL_PP environement variables in the %check section to make the tests more reproducible. All tests pass. Ok. $ rpmlint perl-Params-SomeUtil.spec ../SRPMS/perl-Params-SomeUtil-1.09-1.fc46.src.rpm ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 3 perl-Params-SomeUtil.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Params-SomeUtil/LICENSE === 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 6 filtered, 1 badness; has taken 0.4 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm drwxr-xr-x 2 root root 0 Sep 6 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Sep 6 02:00 /usr/lib/.build-id/0f lrwxrwxrwx 1 root root 72 Sep 6 02:00 /usr/lib/.build-id/0f/0708f600f96a9b77c8ba78aff020931d91c765 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Params/SomeUtil/SomeUtil.so drwxr-xr-x 2 root root 0 Sep 6 02:00 /usr/lib64/perl5/vendor_perl/Params -rw-r--r-- 1 root root 25551 May 4 00:04 /usr/lib64/perl5/vendor_perl/Params/SomeUtil.pm drwxr-xr-x 2 root root 0 Sep 6 02:00 /usr/lib64/perl5/vendor_perl/auto/Params drwxr-xr-x 2 root root 0 Sep 6 02:00 /usr/lib64/perl5/vendor_perl/auto/Params/SomeUtil -rwxr-xr-x 1 root root 23544 Sep 6 02:00 /usr/lib64/perl5/vendor_perl/auto/Params/SomeUtil/SomeUtil.so drwxr-xr-x 2 root root 0 Sep 6 02:00 /usr/share/doc/perl-Params-SomeUtil -rw-r--r-- 1 root root 6668 May 4 00:06 /usr/share/doc/perl-Params-SomeUtil/Changes -rw-r--r-- 1 root root 17983 Feb 7 2026 /usr/share/doc/perl-Params-SomeUtil/README drwxr-xr-x 2 root root 0 Sep 6 02:00 /usr/share/licenses/perl-Params-SomeUtil -rw-r--r-- 1 root root 20576 Feb 6 2026 /usr/share/licenses/perl-Params-SomeUtil/LICENSE -rw-r--r-- 1 root root 6492 Sep 6 02:00 /usr/share/man/man3/Params::SomeUtil.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libperl.so.5.44()(64bit) 1 perl(:MODULE_COMPAT_5.44.0) 1 perl(:VERSION) >= 5.5.30 1 perl(DynaLoader) 1 perl(Exporter) 1 perl(overload) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(vars) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm | sort -f | uniq -c 1 perl(Params::SomeUtil) = 1.09 1 perl-Params-SomeUtil = 1.09-1.fc46 1 perl-Params-SomeUtil(x86-64) = 1.09-1.fc46 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm Binary dependencies are resolvable. Ok. The package build in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=149982883). Ok. The package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2529191 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202529191%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
