Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689039 Hedayat Vatankhah <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Hedayat Vatankhah <[email protected]> 2011-05-03 19:19:56 EDT --- (In reply to comment #2) > Thanks for the review! :) You're welcome > > (In reply to comment #1) > > - semidefinite looks like to be an acceptable word, but if semi-definite is > > a > > better replacement please replace it > > All of the web sites that talk about this approach use "semidefinite", so I > would like to leave it that way. OK. > > > - defattr can be removed from the %files sections as recently added to the > > Packaging Guidelines > > Okay. If I don't need to make any other changes, I'll do this before > importing > the package into git. > > > - Where does Csdp.INDEX file in src.rpm come from? > > I made it. I can add a comment to that effect in the spec file. Yes, please add a comment to the spec file about this. Considering that the above 2 minor edits will be applied upon import to git, this package is considered to be APPROVED by me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
