Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632056 Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|14 |rawhide Flag|fedora-review? |fedora-review+ --- Comment #4 from Rex Dieter <[email protected]> 2011-05-20 11:31:09 EDT --- $ rpmlint *.rpm x86_64/*.rpm libsocialweb-qt.src: W: invalid-url Source0: libsocialweb-qt-0.1.2.tar.bz2 libsocialweb-qt.x86_64: E: incorrect-fsf-address /usr/share/doc/libsocialweb-qt-0.1.2/COPYING libsocialweb-qt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libsocialweb-qt-0.1.2/.moc libsocialweb-qt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libsocialweb-qt-0.1.2/.moc libsocialweb-qt-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 4 warnings. mostly harmless Naming: ok License: ok Sources: meh, though hard to verify as-is. :-/ Builds/installs: ok, though 1. SHOULD: use versioned BuildRequires: rest-devel >= 0.7 2. SHOULD: move sed -i 's|LIBDIR = .*$|LIBDIR = %{_libdir}|' libsocialweb-qt.pro to %prep section, instead of %build macros: ok scriptlets: ok I won't consider those SHOULD items blockers, but please do address them prior to doing any official builds. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
