Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711047 --- Comment #3 from Tom "spot" Callaway <[email protected]> 2011-06-27 10:43:34 EDT --- Quick comments: * You do not need the BuildRoot setting, it is obsolete in all current versions of Fedora. It is only needed for EPEL branches older than 6. * You do not need the rm -rf %{buildroot} at the beginning of %install. It is the default in all current versions of Fedora. It is only needed for EPEL branches older than 6. * You do not need the default %clean section. A %clean that simply deletes the %{buildroot} is the default in all current versions of Fedora. It is only needed for EPEL branches older than 6. * configure seems to be searching for libGL and libGLU, perhaps mesa-libGL-devel, mesa-libGLU-devel should be added as BuildRequires? * make DESTDIR=%{buildroot} install seems to work fine, perhaps you should use it (and just run desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop) * You do not need to explicitly mark manpages as %doc, anything in the mandir is automatically marked as %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
