Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=716299 Elder Marco <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Elder Marco <[email protected]> 2011-06-30 21:29:22 EDT --- Hi, Just a few comments. - You could add build requires dependencies one per line: BuildRequires: gtk2-devel BuildRequires: intltool BuildRequires: desktop-file-utils It's more readable. - Use the full length of a line for description, up to 80 characters. - Consider to add %doc section after %defattr and before the package files. $ rpmlint /var/lib/mock/fedora-15-x86_64/result/clipit-* clipit.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/clipit-startup.desktop 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - Mark the file %{_sysconfdir}/xdg/autostart/%{name}-startup.desktop as %config in the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
