Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718430 Tom "spot" Callaway <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|CANTFIX | Keywords| |Reopened --- Comment #8 from Tom "spot" Callaway <[email protected]> 2011-07-06 10:45:54 EDT --- The License tag is incorrect, based on https://github.com/unknown-horizons/unknown-horizons/blob/master/doc/LICENSE, it should be: License: GPL+ and Python and MIT and CC-BY-SA Also, that file implies that there is a bundled copy of the Libertine fonts, you should use the system copy instead and Requires: linux-libertine-fonts Usually, the simplest way to accomplish that is to rm the files after they're installed and replace them with symlinks. I also noticed a few other things: * You don't need to use %defattr(-,root,root) lines anymore (it is the default). * You don't need to have a %clean rm -rf %{buildroot} section anymore (it is the default). * You don't need to define BuildRoot anymore (rpm sets a sane default, and ignores what you set). * You should be using desktop-file-validate (https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage), and have BuildRequires: desktop-file-utils Update the spec with these fixes, increment the version, add a changelog entry, and I'll continue the review. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
