Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720447 Rahul Sundaram <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Rahul Sundaram <[email protected]> 2011-07-11 20:09:36 EDT --- Run a mock build or koji scratch build. In particular, you need BuildRequires: python-devel BuildRequires: python-setuptools Remove any commented out lines. Use name and version macro for Source0 Contact upstream and ask them to include a copy of the licenses. Especially GPL requires this. Include any licenses in %doc Description can be shortened to: This is a python port of Text::Unidecode Perl module. It provides a function, 'unidecode(...)' that takes unicode data and tries to represent it in ASCII characters. For example, 'unidecode(u"u5317u4EB0")' returns 'Bei Jing'. %defattr(-,root,root,-) is redundant. You don't need this anymore. Might consider moving %doc to be right after %files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
