Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720435 Michal Nowak <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Michal Nowak <[email protected]> 2011-07-13 04:26:08 EDT --- (In reply to comment #0) > epson-inkjet-printer-escpr.src:73: E: hardcoded-library-path in > /usr/lib/cups/filter/epson-* Not good. Look here (https://fedoraproject.org/wiki/Packaging/RPMMacros) for info how to create a valid path via RPM macros. > epson-inkjet-printer-escpr.src: W: invalid-url Source0: > epson-inkjet-printer-escpr-1.0.4-1lsb3.2.tar.gz Place correct URI here, e.g.: http://.../source.tar.gz > epson-inkjet-printer-escpr.x86_64: E: binary-or-shlib-defines-rpath > /usr/lib/cups/filter/epson-escpr ['/usr/lib64'] Look into packaging guidelines for other tips on how to remove RPATH. > epson-inkjet-printer-escpr-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/epson-inkjet-printer-escpr-1.0.4/lib/escpr_sp.h I suggest you work with upstream to change the address -- but I guess it's acceptable for Fedora as it is now. I doubt the version & release fields are OK. I suggest you change the version to "1.0.4-1lsb3.2" and release to "1". > %defattr(-,root,root) A bit old-style, I suggest to use %defattr(-,root,root, -). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
