Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644809 Mo Morsi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Mo Morsi <[email protected]> 2011-07-14 18:09:34 EDT --- Looks good. Koji build is green, http://koji.fedoraproject.org/koji/taskinfo?taskID=3199987 A couple comments - "--ri" should be passed to gem install - as mamoru pointed out %geminstdir/install.rb is still not marked as %doc, not sure if this is intentional though - since specs are shipped with the gem a %check section really should be included and the spec suite run, not strictly required tho would be good to add before pushing if possible The rpmlint issues have been taken care of and the vendorized selenium was removed from the cached gem. This package passes guidelines. APPROVED rubygem-webrat [mmorsi] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
