Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=720086 --- Comment #7 from Bernard Johnson <[email protected]> 2011-07-20 00:20:16 EDT --- (In reply to comment #5) > Minor observations: > > 1. Got a redundant %doc in this one too. Yeah, I already fixed it locally and it will be fixed in the initial package. > 2. Isn't an underscore in front of a macro usually a path by convention? (i.e. > _libdir, _sharedir, _includedir, etc.) Well, that's a good observation and I've never thought about it too much so I checked the output of 'rpm --showrc'. For the vast majority of cases it is a path or program. But that's not only what it's used for (check _c_flags, _arch, etc). In my case, having a software background, I used it to mean "internal", "private" or "only applies here". I don't feel strongly about it one way or the other... it's just a variable to make life easier :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
